[Github-comments] [geany/geany] Hide overwrite button for readonly documents. (PR #3142)

Guido Falsi notifications at github.com
Tue Mar 29 13:51:26 UTC 2022


I understand not wanting to remove the functionality, but also not getting notified of the on disk file having changed does not look correct. I interpreted "readonly" as an indication that the file would never be written to, not as "will not allow modifications in the buffer". With this new interpretation I should reassess the whole idea I had about how things should work. I assumed one meaning of readonly and adjusted the code to that.

With this new idea I'm not sure what is the best, maybe a global configuration option, specifying the expected behavior of readonly, or a new file property, which I'm not sure how to name (something like "never overwrite"), to specify the file should never be written to, but can be monitored for changes, completely orthogonal to the current readonly setting.

Since all these options require definitely more work than my simplistic approach, I'm not sure if I can find time to do such changes in the near future.

What would be the preferred/more acceptable behavior?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3142#issuecomment-1081899058
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3142/c1081899058 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220329/6b2a56bd/attachment.htm>


More information about the Github-comments mailing list