[Github-comments] [geany/geany] Move symbol tree root mappings to tm_parser.c (PR #3137)

[Jiří Techet]

> The principles (as much as I understand them from the description) seem sound, but I'm not sure anyone but @b4n could review it, if he remembers any Geany now. Unless someone else wants to become a tagmanager expert to assist @techee.

The times of unreviewable PRs posted by me are fortunately over and this PR _isn't_ one of them actually - the biggest bulk of this PR is "just" the moving of the language mappings to `tm_parser.c` and updating them to the new way of mapping, the actual "real" code change is maybe just around 100 LOCs and perfectly reviewable. And it's not much of the TM stuff that is affected by this PR, it's rather the `symbols.c` stuff.

The most worrisome part of this PR for me is the `"just" moving and updating the mapping` part for all the languages. I __really__ tried to do it carefully but one gets slightly delirious at language number 30 with 15 more remaining and it's always possible I might have introduced some error.

Anyway, after all the uctags parsers are merged (I'll wait with the remaining ones until this PR is merged), I plan to do a big testing session checking if everything works.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3137#issuecomment-1074929827
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3137/c1074929827 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220322/3a31ca79/attachment.htm>