[Github-comments] [geany/geany] Move symbol tree root mappings to tm_parser.c (PR #3137)

elextr notifications at xxxxx
Tue Mar 22 01:02:37 UTC 2022


> This is hopefully the last of the big TM-related refactorings from me to improve ctags parser management. I'll be nice afterwards, I promise :-).

Thats what you said last time, and the time before and ... :-P

But we are not grateful to you for shouldering that load.

The principles (as much as I understand them from the description) seem sound, but I'm not sure anyone but @b4n could review it, if he remembers any Geany now.  Unless someone else wants to become a tagmanager expert to assist @techee.

If it doesn't get reviewed in a reasonable time but it seems to work for anyone testing it, I would suggest that it be merged and the next release be 1.99 (ie pre-2.0, so 2.0 can be stable, that would allow any other "too complex to review in detail" but "test ok for the things testers try" changes to be merged as well).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3137#issuecomment-1074571190
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3137/c1074571190 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220321/989cb1ef/attachment.htm>


More information about the Github-comments mailing list