[Github-comments] [geany/geany-plugins] GitChangeBar: Support libgit2 1.4.x (PR #1165)

[Enrico Tröger]

@eht16 commented on this pull request.



> @@ -49,6 +49,11 @@
 # define git_buf_dispose  git_buf_free
 # define git_error_last   giterr_last
 #endif
+#if ! defined (LIBGIT2_VER_MINOR) || ( (LIBGIT2_VER_MAJOR == 1) && (LIBGIT2_VER_MINOR < 4) )
+# define gcb_git_buf_reserved asize

I ruled out `if`ing the two occurrences pretty early. Since there are already compability macros in place, it seemed appropriate to follow this pattern here.

Regarding the whitespace changes: should I remove them from this PR?
For reviewing, you can also hide them in the "Files" tab here:
![github_files_no_whitespace](https://user-images.githubusercontent.com/617017/158699433-552a69e7-70f2-4fd4-9e67-32ffa778a60e.png)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1165#discussion_r828491716
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1165/review/912334388 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220316/fe489afb/attachment.htm>