[Github-comments] [geany/geany] Update sci_get_selected_text_length() after change to Scintilla 5.1.5 (PR #3099)

[Enrico Tröger]

> I'm just not getting the depreciation warnings when using `GEANY_DEPRECATED_FOR`. Am I doing something wrong?

This is probably intended. I understand https://github.com/geany/geany/blob/master/src/geany.h#L58 so thst those deprecation warnings are only generated if `GEANY_PRIVATE` is *not* defined. When building Geany itself, `GEANY_PRIVATE` *is* defined.
So, not seeing these messages is ok when building Geany. I guess in plugins they would appear.

BTW on the topic: I like the idea of `sci_get_selected_text_length2()` and to deprecate `sci_get_selected_text_length`. I'm thinking about a better name for the new function, so far without a good result unfortunately :(.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3099#issuecomment-1021679192
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3099/c1021679192 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220125/c8c83525/attachment.htm>