[Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Eli Schwartz]

@eli-schwartz commented on this pull request.



> +    dep_doxygen = declare_dependency(sources: ['plugins.dox',
+                                               'pluginsignals.c',
+                                               'pluginsymbols.c',
+                                               'stash-example.c',
+                                               'stash-gui-example.c'])
+
+    custom_target('doxygen.stamp',
+                  input: dox,
+                  output: ['doxygen.stamp'],
+                  command: [doxygen, '@INPUT@', '&&', 'touch', '@OUTPUT@'],
+                  depends: libgeany,
+                  build_by_default: true)
+    doxy_xml = custom_target('doxygen-gi.stamp',
+                             input: doxgi,
+                             output: ['doxygen-gi.stamp'],
+                             command: [doxygen, '@INPUT@', '&&', 'touch', '@OUTPUT@'],

As a matter of curiosity, why is this the fault of meson rather than the fault of embedding shell scripts as data?

```meson
command: [sh, '-c', 'doxygen @INPUT@ && touch @OUTPUT@'],
```

is inherently broken, because what happens if `@INPUT@` or `@OUTPUT@` have spaces in them? Or any of a number of other character sequences that would break a shell script?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#discussion_r790349137
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/2761/review/860390213 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220123/7019a0eb/attachment.htm>