[Github-comments] [geany/geany] Add GDScript file type (PR #3012)

Jiří Techet notifications at xxxxx
Tue Jan 11 23:51:52 UTC 2022


@Davidy22 Could you make the patch on top of current master? There was a problem with the update to new Scintilla that caused crashes and your branch crashed because of that too.

I just had a brief look at the pull request. Could you add some unit test that generates all the kinds supported by the parser? Also, I expect the parser generates full scope information - in such case it should be mentioned in the top part of `tm_parser_has_full_context()`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3012#issuecomment-1010481981
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3012/c1010481981 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/6d37c460/attachment-0001.htm>


More information about the Github-comments mailing list