[Github-comments] [geany/geany] Filter for symbol tree - improved version (PR #3055)

Jiří Techet notifications at xxxxx
Thu Jan 6 17:25:58 UTC 2022


> Gentle prompt, its a UI change and new functionality so manual change also needed.

I actually haven't found anything in the documentation regarding the symbol tree (unless I missed it) so I'd have to write some new section about it. In my opinion, the tooltip says it all and there shouldn't be any need for any extra explanation.

> Maybe we should consider what widget in the sidebar gets the focus by default - right now it's the entry (and the tree focus is just one tab or enter press away) but maybe users who use primarily keyboard are more used to having the tree focused. I don't mind much myself as I just use mouse for the tree.

I kept the focus as it is now - it seems to behave quite OK and and it would require moving

https://github.com/geany/geany/blob/0601c73f7a7abc40fe9ddbff6b906b0d0e5b5f79/src/keybindings.c#L1700

to `sidebar.c` so it has access to the tree to call `gtk_widget_grab_focus()` and also updating

https://github.com/geany/geany/blob/0601c73f7a7abc40fe9ddbff6b906b0d0e5b5f79/src/sidebar.c#L1143

None of it is a problem to do though if someone wants to focus the tree by default.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3055#issuecomment-1006768814
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3055/c1006768814 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220106/818c357d/attachment.htm>


More information about the Github-comments mailing list