[Github-comments] [geany/geany] Update doc->priv->tag_tree_dirty only if doc is set (PR #3080)

[Jiří Techet]

@techee commented on this pull request.



> @@ -191,7 +191,7 @@ void sidebar_update_tag_list(GeanyDocument *doc, gboolean update)
 
 	g_return_if_fail(doc == NULL || doc->is_valid);
 
-	if (update)
+	if (update && doc != NULL)

Definitely good to add, this code was actually written by me and I think I just fell into the misunderstanding of the `g_return_if_fail()` trap above.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3080#pullrequestreview-842449461
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3080/review/842449461 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220102/b0395941/attachment-0001.htm>