[Github-comments] [geany/geany] Update doc->priv->tag_tree_dirty only if doc is set (PR #3080)

elextr notifications at xxxxx
Sun Jan 2 21:43:03 UTC 2022


@elextr approved this pull request.

ignore spurious comment, is ok

> @@ -191,7 +191,7 @@ void sidebar_update_tag_list(GeanyDocument *doc, gboolean update)
 
 	g_return_if_fail(doc == NULL || doc->is_valid);

Maybe this should be doc != NULL?

> @@ -191,7 +191,7 @@ void sidebar_update_tag_list(GeanyDocument *doc, gboolean update)
 
 	g_return_if_fail(doc == NULL || doc->is_valid);

erm, no, its or not and, please ignore

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3080#pullrequestreview-842446033
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3080/review/842446033 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220102/39ca067f/attachment-0001.htm>


More information about the Github-comments mailing list