[Github-comments] [geany/geany] Filter for symbol tree - improved version (PR #3055)

Enrico Tröger notifications at xxxxx
Sun Jan 2 16:18:54 UTC 2022


@eht16 commented on this pull request.



>  		sidebar_select_openfiles_item(doc);
 		ui_save_buttons_toggle(doc->changed);
 		ui_set_window_title(doc);
 		ui_update_statusbar(doc, -1);
 		ui_update_popup_reundo_items(doc);
 		ui_document_show_hide(doc); /* update the document menu */
 		build_menu_update(doc);
-		sidebar_update_tag_list(doc, FALSE);
+		if (g_strcmp0(entry_text, doc->priv->tag_filter) != 0)
+			gtk_entry_set_text(filter_entry, doc->priv->tag_filter);

Could the following maybe be enough:
```c
		if (g_strcmp0(entry_text, doc->priv->tag_filter) != 0)
		{
			gtk_entry_set_text(filter_entry, doc->priv->tag_filter);
		}
		else
		{
			sidebar_update_tag_list(doc, TRUE);
		}
```
?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3055#discussion_r777229190
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3055/review/842427793 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220102/d0c9998e/attachment.htm>


More information about the Github-comments mailing list