[Github-comments] [geany/geany-plugins] GeanyLua: Update for Scintilla 5.1.4 (PR #1123)

[Enrico Tröger]

@Skif-off true, the #3046 does not change the generated `gsdlg.h` and also don't contain any other obvious changes which are related. So this PR is independent of the pending Scintilla update.

It doesn't look bad, I just did not yet understand why the many parameter handling changes are necessary.
The commit message of b0b1b2acc226938dc37723cd1d2366fc2785b611 is not very verbose. I see there are new parameter types added but also some existing code moved and so potential logic changed. This is probably ok, I just cannot see why.
@xiota can you shed some light on this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1123#issuecomment-1003576920
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1123/c1003576920 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220101/154b5b5e/attachment.htm>