[Github-comments] [geany/geany] Null time on debug messages (Issue #3071)

[Enrico Tröger]

Oops, I didn't notice because I used recent enough GLib versions on Windows and Linux :(.

> @rdipardo thanks for working on this.

+1

> if compiled against a new enough version and the runtime version is same or newer (the glib_check_version)
> then use microseconds 
> else use seconds

I'm missing something probably but my attempt is way simpler by just checking the GLib version at runtime to decide whether to use `%f` or not. See below.

> Whilst the microseconds can be useful, we got by without until now, so IMHO its not critical to provide it, but it is critical to always get a time. (@eht16 agree?)

I fully agree that the log date without microseconds is more important than no log date.

> This case gets complicated because we want to provide a workaround, not fail, and the incompatibility is just the contents of a string not a missing function so its really hidden.

I don't see a problem in using `glib_check_version()`, especially in this case where it is as easy as to just modify the string. We don't need compile time checks as there is no API involved.

https://github.com/geany/geany/pull/3076 tries to fix it by using `glib_check_version()` and remove microseconds if GLib version is older than 2.66.0 (which is the relevant stable release after 2.65.2).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3071#issuecomment-1003541453
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3071/1003541453 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220101/7690d120/attachment.htm>