[Github-comments] [geany/geany] Add "el" as "Lisp" filetyp extension (PR #3130)

Codeberg-AsGithubAlternative-buhtz notifications at xxxxx
Wed Feb 23 13:07:51 UTC 2022


@Codeberg-AsGithubAlternative-buhtz commented on this pull request.



> @@ -47,7 +47,7 @@ JSON=*.json;
 Julia=*.jl;
 Kotlin=*.kt;*.kts;
 LaTeX=*.tex;*.sty;*.idx;*.ltx;*.latex;*.aux;
-Lisp=*.lisp;
+Lisp=*.lisp;*.el

> Note the semicolon is not required, but every other line has one, so better to be consistent to avoid questions about why.

I agree with the goal to be consistent to avoid questions and wasting support resources. But I would vote for another approach to reach that goal.
IMHO it is unusual (for the most users) to have line endings like this. That is why I "forgot" them first. I am not aware of a language/file-format/notation that ask for such line endings. I assume that other users/committers would forget them, too. Which would waste resources in reviewing such PR's.

Because of that and if you agree I would create a follow-up PR removing all line-ending semicolon.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3130#discussion_r812871698
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3130/review/891054160 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220223/c0a31779/attachment-0001.htm>


More information about the Github-comments mailing list