[Github-comments] [geany/geany] Remove deprecated symbol: tm_get_real_path (PR #3024)

[elextr]

@elextr commented on this pull request.



> @@ -2436,7 +2463,12 @@ void utils_start_new_geany_instance(const gchar *doc_path)
 GEANY_API_SYMBOL
 gchar *utils_get_real_path(const gchar *file_name)
 {
-	return tm_get_real_path(file_name);
+	gchar *path = NULL;
+
+	if (file_name)
+		path = realpath(file_name, NULL);

Agree with @kugel-, the fatally broken `realpath()` has left the building, the projects where I have noticed all now assume the [POSIX 2008](https://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html) behaviour with NULL, nobody tries to allocate themselves, so the only choice is between Windows and POSIX.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3024#discussion_r810384015
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3024/review/887816503 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220218/e265a787/attachment.htm>