[Github-comments] [geany/geany] Imports and enables Asciidoc lexer from Lexilla 5.1.4 (PR #3097)

Thomas Martitz notifications at xxxxx
Fri Feb 11 12:03:34 UTC 2022


@kugel- commented on this pull request.



> @@ -142,7 +142,8 @@ val SCLEX_HOLLYWOOD=130
 val SCLEX_RAKU=131
 val SCLEX_FSHARP=132
 val SCLEX_JULIA=133
-val SCLEX_GDSCRIPT=134
+val SCLEX_ASCIIDOC=134
+val SCLEX_GDSCRIPT=135

Well, not really a bug. We don't use LexicalStyles.iface for anything, therefore it's not copied on import. I guess I simply copied the whole `lexilla/include` dir when doing the initial lexilla import while the script explicitly only copies `lexilla/include/*.h` (just checked).

So I guess we should decide if we ether drop the file completely or fix the update script to import it correctly. What do you think?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3097#discussion_r804587821
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3097/review/880091090 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220211/0e52f4d9/attachment.htm>


More information about the Github-comments mailing list