[Github-comments] [geany/geany] Imports and enables Asciidoc lexer from Lexilla 5.1.4 (PR #3097)

Thomas Martitz notifications at xxxxx
Thu Feb 10 21:08:42 UTC 2022


@kugel- requested changes on this pull request.



> @@ -1,35 +1,33 @@
 # For complete documentation of this file, please see Geany's main documentation
 [styling]
-# no syntax highlighting yet
+# Edit these in the colorscheme .conf file instead
+default=default
+strong=default,bold
+emphasis=default,italic
+header1=keyword_1
+header2=keyword_1
+header3=keyword_1
+header4=keyword_1
+header5=keyword_1
+header6=keyword_1
+ulist_item=default
+olist_item=default
+blockquote=default,italic

Markdown uses tag_unknown for the above 3. Since markdown is similar in spirit it might make sense to align to that.

>  
 [settings]
 # default extension used when saving files
-extension=asciidoc
+extension=adoc

seems adoc is recommended by https://asciidoctor.org/docs/asciidoc-recommended-practices/, I don't know how "official" that source is.

> @@ -142,7 +142,8 @@ val SCLEX_HOLLYWOOD=130
 val SCLEX_RAKU=131
 val SCLEX_FSHARP=132
 val SCLEX_JULIA=133
-val SCLEX_GDSCRIPT=134
+val SCLEX_ASCIIDOC=134
+val SCLEX_GDSCRIPT=135

Why do we need to change this file at all?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3097#pullrequestreview-879459833
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3097/review/879459833 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220210/577e04c3/attachment-0001.htm>


More information about the Github-comments mailing list