[Github-comments] [geany/geany-plugins] GeanyVC:(Git) Fallback to `git rev-parse` for getting the repo/worktree's top directory (#1028)

[elextr]

> Just re-checked, the behavior complies with the use-case listed in the https://github.com/geany/geany-plugins/issues/285 for what it's worth.

To be clear, I don't use geanyvc, so I won't spend time understanding enough of the plugin code to be able to review the change, similarly setting up a sacrificial git repo to test it.  Especially when related to git workflows and stuff.  

Although it would be preferable that some other user (like the OP of #285) tests it, in the end if it sits too long and nobody does then IMHO if the plugin maintainer says so (and the build passes) it should be merged.  

Can you trigger the new CI by pushing an inconsequential change, after all its a year since it was tested, I'm sure there is a comment that needs improving/adding :-) 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1028#issuecomment-1109227426
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1028/c1109227426 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220425/046aac9e/attachment.htm>