[Github-comments] [geany/geany] Add Prolog filetype support (PR #3171)

[Robert Di Pardo]

@techee,
It looks like the primary keyword set in your last commit left out the VisualProlog type specifiers [1] (or ["Domains"][0], as the spec calls them). Compare the appearance of `unsigned` in my [earlier screen capture][2] with the one below (in the [Himbeere colorscheme](https://github.com/geany/geany-themes)):

![geany_himbeere_visualprolog_hl](https://user-images.githubusercontent.com/59004801/165013360-9ab0265f-1bbf-4a42-b5f7-31476368ddf6.png)

I'm confident that SWI-Prolog users will be completely happy 👍🏼 

![geany_himbeere_swi-pl-hl](https://user-images.githubusercontent.com/59004801/165013510-0c2ea3ca-7ac2-49fb-a8d5-dba47fc17b9f.png)


They're getting more lexical categories than even the VS Code extension recognizes. Notice, however, that `append` and `multifile` are styled by VS Code but not Geany:

![vscode_swi-pl_hl](https://user-images.githubusercontent.com/59004801/165013570-7bb85e59-3d2f-4a22-9c74-4a76b1965056.png)

Neither is as complete as [prolog.vim](https://github.com/yochem/prolog.vim), but I think we have to accept that regex-capable parsers like Vim and Textmate grammars are simply better than Scintilla's match-every-character-of-one-lexeme-at-a-time model:

![prolog vim_swi-pl_hl](https://user-images.githubusercontent.com/59004801/165013653-8a8608a3-2254-4a07-88ef-4a668c44647b.png)

---

[1]: See https://github.com/rdipardo/geany/commit/3baa85baa25cd36b4d0e437fe7cd7383a8299fc5
      The complete list is quite brief:

    any
    binary
    binaryNonAtomic
    boolean
    char
    compareResult
    factDB
    handle
    integer64
    integerNative
    null
    pointer
    real
    real32
    string8
    symbol
    unsigned
    unsigned64
    unsignedNative


[0]: https://wiki.visual-prolog.com/index.php?title=Language_Reference/Built-in_entities#Domains
[2]: https://user-images.githubusercontent.com/59004801/163895249-93885a44-09dd-457f-af0f-8a4e43270f71.png

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3171#issuecomment-1108031562
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3171/c1108031562 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220424/7db20530/attachment.htm>