[Github-comments] [geany/geany] Use gtk_show_uri_on_window() in utils_open_browser() by default (PR #3178)

Thomas Martitz notifications at github.com
Sun Apr 24 12:28:05 UTC 2022


Instead of requiring the user to specify a browser just try to
use the system default browser through gtk_show_uri_on_window().
This is done when tool_prefs.browser_cmd is empty which is
also the new default.

This aligns with windows where we do this already. Though we're
bypassing tool_prefs.browser_cmd there entirely, while on non-Windows
we still honor tool_prefs.browser_cmd when it's set.

This is primarily useful for flatpak support where we cannot just
execute arbitrary commands on the host (unless using flatpak-spawn).

Also, firefox is arguably a bad default these days, given the
declined marked share.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3178

-- Commit Summary --

  * Use gtk_show_uri_on_window() in utils_open_browser() by default

-- File Changes --

    M data/geany.glade (1)
    M src/keyfile.c (4)
    M src/utils.c (18)

-- Patch Links --

https://github.com/geany/geany/pull/3178.patch
https://github.com/geany/geany/pull/3178.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3178 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220424/03744023/attachment.htm>


More information about the Github-comments mailing list