[Github-comments] [geany/geany] Use the upstream VHDL parser (PR #3158)

Jiří Techet notifications at github.com
Mon Apr 18 13:58:52 UTC 2022


> I didn't look at the upstream parser and I don't really want to. I trust you that it's better (or at least on par) than our existing parser.

This is a token-based parser unlike the previous readline-based parser (similarly to the TCL, Latex) which in general should be better and the development should go towards it instead of maintaining the previous parser. That of course doesn't mean that the previous parser didn't parse something better by accident but at least for the unit tests it seems to be the same (or better).

>From the remaining parsers, I upstreamed all the Fortran changes we had (and the upstream parser had some improvements of its own) and I wrote the Markdown parser (based on the Asciidoc parser we had) because the previous parser was quite bad.

> Do you think the new test files have about the same coverage or do we lose anything?

4 kinds seem to be really missing. I think I'll write some script checking if our parsers cover all the ctags kinds because it's easy to miss some tags.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3158#issuecomment-1101429436
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3158/c1101429436 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220418/569fda26/attachment.htm>


More information about the Github-comments mailing list