[Github-comments] [geany/geany] Add option to show symbols in symbol tree without root groups (PR #3172)

Jiří Techet notifications at github.com
Mon Apr 18 13:46:42 UTC 2022


> Knowing the (semi-related) code for the documents list pretty good by now (courtesy of https://github.com/geany/geany/issues/1812) I don't think it's that bad

That code is for babies really ;-).

The symbol tree code spans from line 260 to line 1260 in symbols.c. It doesn't re-create the tree when something changes like the documents list - it really updates the tree by first removing invalid entries and then adding new entries, otherwise the tree would scroll all the time when you add or remove something that generates a tag. Multiple hash tables are involved in constructing it to detect the changes. If there's one piece of code to fear in Geany, it's the symbol tree code (followed by scope autocompletion). I already did some things in the past with the symbol tree to optimize it and developed quite a bit of respect to it - it works, it's very fragile because even small changes tend to break it, and better not to touch it much.

In any case, anyone brave enough is encouraged to improve it :-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3172#issuecomment-1101421500
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3172/c1101421500 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220418/54b979dc/attachment.htm>


More information about the Github-comments mailing list