[Github-comments] [geany/geany-plugins] GitChangeBar: Support libgit2 1.4.x (PR #1165)

[elextr]

> At least, the changes in this PR won't make it worse than the other compatibility macros before, I'd say.

I didn't think it had any compatibility checks before, thats why it refused to compile with a version of libgit2 that had `reserved` not `asize`.

I probably have not explained my concerns well enough.  

I am not an expert on libgit, but IIUC the change in libgit is not simply that the field name was changed, but that the field is now unused.  But this patch still tests and assigns to the unused field.  But whatever value it is testing for will not be set and whatever value it is trying to pass are ignored by libgit because the field is unused.  

It seems to me that if the test is still needed or the value is still supposed to be passed to libgit then we should be testing something else, or passing the value somewhere else, not using `reserved` as if it is still `asize`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1165#issuecomment-1089508755
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1165/c1089508755 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220405/2158cb3e/attachment.htm>