[Github-comments] [geany/geany] Remove redundant code (#2890)
Avinash Sonawane
notifications at xxxxx
Sun Sep 5 13:25:31 UTC 2021
Hello!
While chasing down these `clang` warnings I found that some code is redundant and can be safely removed:
```
main/parse.c:5007:26: warning: unused function 'FallbackParser' [-Wunused-function]
static parserDefinition *FallbackParser (void)
^
main/parse.c:5040:26: warning: unused function 'CTagsParser' [-Wunused-function]
static parserDefinition *CTagsParser (void)
^
main/parse.c:5355:26: warning: unused function 'CTagsSelfTestParser' [-Wunused-function]
static parserDefinition *CTagsSelfTestParser (void)
^
```
This is because we explicitly define `EXTERNAL_PARSER_LIST ` in tm_parsers.h at https://github.com/geany/geany/blob/master/src/tagmanager/tm_parsers.h#L16 so guess no need to check for not defined case?
Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2890
-- Commit Summary --
* Remove redundant code
-- File Changes --
M ctags/main/parse.c (338)
M ctags/main/parse_p.h (13)
-- Patch Links --
https://github.com/geany/geany/pull/2890.patch
https://github.com/geany/geany/pull/2890.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2890
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210905/a048e7ce/attachment.htm>
More information about the Github-comments
mailing list