[Github-comments] [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1128)

[elextr]

@elextr commented on this pull request.



> @@ -194,14 +194,15 @@ replace_all(MarkdownViewer *self,
 {
   gchar *ptr;
   gsize needle_len = strlen(needle);
+  gsize replacement_len_minus_one = strlen(replacement) - 1;

Ahh, the obligatory C programming off by one bug :smile:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1128#discussion_r739125625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211029/b4c746d3/attachment.htm>