[Github-comments] [geany/geany] Improve auto close (#2943)

xiota notifications at xxxxx
Thu Oct 28 21:04:43 UTC 2021


@xiota commented on this pull request.



>  
 static void auto_close_chars(ScintillaObject *sci, gint pos, gchar c)
 {
 	const gchar *closing_char = NULL;
-	gint end_pos = -1;
-
-	if (utils_isbrace(c, 0))
-		end_pos = sci_find_matching_brace(sci, pos - 1);

As far as I can tell, the autoclose plugin does not do any checking for whether Geany is already autoclosing. Yet when both the plugin and Geany autoclose are enabled, only a single closing brace appears in the editor. It's possible that Geany not closing braces when a matching brace is found is why the plugin does not "conflict" with built-in autoclose. (See #2970.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2943#discussion_r738774517
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211028/3dced4a3/attachment.htm>


More information about the Github-comments mailing list