[Github-comments] [geany/geany] Update to Scintilla 5.1.3 and Lexilla 5.1.2 (#2930)

[elextr]

@elextr commented on this pull request.



> @@ -388,7 +388,12 @@ static const HLStyle highlighting_styles_CSS[] =
 	{ SCE_CSS_EXTENDED_IDENTIFIER,		"extended_identifier",		FALSE },
 	{ SCE_CSS_EXTENDED_PSEUDOCLASS,		"extended_pseudoclass",		FALSE },
 	{ SCE_CSS_EXTENDED_PSEUDOELEMENT,	"extended_pseudoelement",	FALSE },
-	{ SCE_CSS_MEDIA,					"media",					FALSE }
+	{ SCE_CSS_GROUP_RULE,				"group_rule",				FALSE },
+	/* In Geany 1.38 and earlier shipped filetypes.css with "media" identifier,
+	 * Scintilla/Lexilla 5.1.2 has renamed this style and extended its meaning.
+	 * We still recognize media for compatibility.
+	 */
+	{ SCE_CSS_GROUP_RULE,				"media",					FALSE }

I had some time to check again (after reading W3C tutorial on @media etc) and I agree with @eht16, using %Y in the status bar I can see that `media` and `document` in `@media` and `@document` is styled 22 but the applied named style is `default` (after editing `filetypes.common` to make`default` and `parameter` named styles blindly obvious :), so as usual @eht16 is right ;-P.   But if I remove the line above, the applied named style is `parameter`.

@kugel- it was a good idea, but it doesn't work.  I don't think its necessary to retain backward compatibility with syntactic entity names, previously `media` and now `group-rule` is mapped to the `parameter` named style which is what the colour schemes should be changing, so they will still work.  

It would only be when someone who changed the named style that `media` mapped to in their `filetypes.css` that would not "just work" but they would probably be smart enough to change it again when the new Geany comes out especially if its highlighted in the next release NEWS.  Maybe add it to NEWS now so its not forgotten.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2930#discussion_r736056727
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211025/17b9fba8/attachment.htm>