[Github-comments] [geany/geany] Don't reopen project files that are already open (PR #2951)

[elextr]

> Popup to warn about closing project – waste time closing popup.

#2949 means you can avoid this if you don't want it :smile:

> Geany doesn't take focus when it creates popups ­– waste time switching to Geany when it would otherwise take focus.

IIRC all Geany popups are marked modal, so they should take focus, but it is up to the window manager/wayland compositor to grant that.  Seems to work here with Cinnamon.

> Nothing useful.

Ok, but project load does cause a signal that plugins might use, do the project plugins do rescans or other stuff when that happens.

> When a project is opened from the menu, no warning is generated. 

Oh, Ok, well no need to add one then, coulda sworn it did, but maybe its been removed, maybe github search knows ... ahh, it used to for a "recent project" open, but that was removed in https://github.com/geany/geany/commit/f40569d1c327af162726dbab14a78fd83ca5e0b8.

> The GeanyProject struct does not appear to have a real_path component.

Yeah, I said "technically", but absolute should be fine most of the time to distinguish two files of the same name in differing directories, only getting confused for smarties with multiple paths to the same file, but in that case its no different to the current situation, so no need for real_path.  

> app->project->file_name contains the full path.

Do you get an absolute path from the socket buffer then?

BTW I am not saying this PR is a bad idea, just want to be sure the implementation has no negative side effects.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2951#issuecomment-950260627
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211023/330787d0/attachment.htm>