[Github-comments] [geany/geany] Update to Scintilla 5.1.3 and Lexilla 5.1.2 (#2930)

[elextr]

@elextr commented on this pull request.



> @@ -179,6 +180,18 @@ GdkAtom SelectionOfGSD(GtkSelectionData *sd) noexcept {
 	return gtk_selection_data_get_selection(sd);
 }
 
+bool SettingGet(GtkSettings *settings, const gchar *name, gpointer value) noexcept {

This looks like the only change that is likely to cause segfaults on widget destroy of the main window if these settings are added to the Scintilla widget and the memory is double released?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2930#pullrequestreview-781433788
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211017/d16e8062/attachment.htm>