[Github-comments] [geany/geany] Improve auto close (#2943)

Jeremias Kleer notifications at xxxxx
Fri Oct 15 10:37:20 UTC 2021


> Its good that you actually made changes to the manual, although I don't think it actually explains the operation very well, and it doesn't explain your second {} commit. That means I may misunderstand what your proposal does, but it sounds quite similar to the way Eclipse works.

I made those changes 2(?) years ago and worked with a own-built version. But as I upgraded Geany recently I again found the situation with auto-closing. I rethinked my decision not to go further with the PR. So I must recap the changes from back then.

It's rather long ago I used Eclipse so I don' know.

> What I find is that Eclipse autoclose might make sense when writing new code, it is a pain in the [colloquial expression elided] when editing existing code. Even Eclipse with all its language smarts breaks roughly 50% of the time when editing existing C++ code, adding extra closing brackets in the wrong places or omitting them when it shouldn't.
> 
> With the best will in the world, Geany does not have the smarts of Eclipse, so I'm rather pessimistic about autoclose. Could you perhaps explain explicitly the logic after your changes, the OP and commit messages do not really clearly explain the intended logic?

I will recap my changes from back then. I will try to do better.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2943#issuecomment-944194838
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211015/a993a61a/attachment.htm>


More information about the Github-comments mailing list