[Github-comments] [geany/geany] Remove deprecated symbol: tm_get_real_path (PR #3024)

[xiota]

@xiota commented on this pull request.



> @@ -2414,6 +2419,48 @@ void utils_start_new_geany_instance(const gchar *doc_path)
 }
 
 
+
+static int get_path_max(const char *path)
+{
+#ifdef PATH_MAX
+	return PATH_MAX;
+#else
+	int path_max = pathconf(path, _PC_PATH_MAX);
+	if (path_max <= 0)
+		path_max = 4096;
+	return path_max;
+#endif

Should the return value be tested and if NULL fallback to preallocating the buffer with max_path?  Or just let it fail if a platform doesn't support this use?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3024#discussion_r758829856
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211129/561aed3f/attachment.htm>