[Github-comments] [geany/geany] Add a confirmation dialog on search & replace for the whole session (PR #3033)

Enrico Tröger notifications at xxxxx
Mon Nov 29 13:59:29 UTC 2021


> I'm generally against adding more popups. If there's truly no better way to solve the problem, at least 

Noted, actually already before. But this doesn't mean adding a new popup to inform the user or request a confirmation is generally a bad idea. As I do accept, that popups might annoy some users, it would be nice if you could also accept that it is still a valid UX option for interaction, even if you personally do not like it.

> After making the mistake twice, aren't you going to be more careful going forward? If there were a dialog "protecting" you, you might not be as careful, get into the habit of mindlessly accepting, then ... 

I disagree. Some confirmation dialogs might increase a habit of just clicking them away. But this case is different as it is more of a guard to a potential harmful feature if not used explicitly. This is the whole intention of this change.

And regarding the referenced mistake: it's not like that I chose "in session" and then wondered what I had done. It is rather that the buttons are quite close and so it's not that unlikely, at least for some people, to accidentally chose the wrong button. I personally am much more aware now which button to choose but my intention also is to prevent other users from the misfortune I did.
Obviously, all of this will never happen for you. Noted.


@elextr 
> In addition (at least the size the replace popup that shows by default here) there is space to the left of the "In Session" button, maybe it can be stacked left to keep it separate from "In Document" and "In 

No space here with my GTK theme with a default config:
![geany_sar_dialog](https://user-images.githubusercontent.com/617017/143880626-9ffeb3ce-fd80-4003-8669-1cd495eb246f.png)

It might be an option to redesign the dialog to visually separate the 'In Session' more from the other ones but this would most likely make the dialog bigger at all. And regarding that presumably this feature is not often used (I anticipate even without the elsewhere request user tracking analytics), I think it's appropriate to use a popup for confirmation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3033#issuecomment-981659117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211129/ac0560b0/attachment.htm>


More information about the Github-comments mailing list