[Github-comments] [geany/geany] Use relative paths for project session files if base directory is relative (PR #3021)

[xiota]

@xiota commented on this pull request.



> @@ -1268,6 +1287,16 @@ static gboolean open_session_file(gchar **tmp, guint len)
 	unescaped_filename = g_uri_unescape_string(tmp[7], NULL);
 	locale_filename = utils_get_locale_from_utf8(unescaped_filename);
 
+	if (!g_path_is_absolute(locale_filename) && app->project)

> That should simply never happen...

Even though this PR doesn't write relative paths in certain ways, session and project files can be edited externally or another PR may change it.  Right now, it looks like such files would be dropped.  It would be nice to know whether that behavior is intentional in case someone wants to change it someday (eg, as part of the config/session split).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3021#discussion_r757437835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211126/9709d9da/attachment.htm>