[Github-comments] [geany/geany] Use relative paths for project session files if base directory is relative (PR #3021)

xiota notifications at xxxxx
Thu Nov 25 22:41:47 UTC 2021


@xiota commented on this pull request.



> @@ -1268,6 +1287,16 @@ static gboolean open_session_file(gchar **tmp, guint len)
 	unescaped_filename = g_uri_unescape_string(tmp[7], NULL);
 	locale_filename = utils_get_locale_from_utf8(unescaped_filename);
 
+	if (!g_path_is_absolute(locale_filename) && app->project)

Could you add a comment to note that this block unpacks relative paths for project session docs?  (So people looking at it later will know what it's doing without having to stare at the code.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3021#pullrequestreview-816320519
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211125/0ccc2c75/attachment.htm>


More information about the Github-comments mailing list