[Github-comments] [geany/geany] Avoid re-scanning the string (PR #2962)

[xiota]

@xiota commented on this pull request.



> @@ -1057,13 +1057,13 @@ gboolean build_parse_make_dir(const gchar *string, gchar **prefix)
 	if (string == NULL)
 		return FALSE;
 
-	if ((pos = strstr(string, "Entering directory")) != NULL)
+	if ((pos = strstr(string, "Entering directory `")) != NULL)

Changing the string in the if-conditional could break something later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2962#pullrequestreview-815616754
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211124/dee29c23/attachment.htm>