[Github-comments] [geany/geany] Avoid re-scanning the string (PR #2962)

xiota notifications at xxxxx
Thu Nov 25 06:28:45 UTC 2021


The problem with `strlen("Entering directory '")` is `strlen` runs in linear time... basically equivalent to just rescanning the string.  (Don't know whether compilers can optimize it to a constant.)

You're also including two chars ` '` that haven't been scanned yet, and it's the wrong quote char (`'` vs <code>`</code>)... so the latest push won't work anymore.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2962#issuecomment-978876394
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211124/674e71c0/attachment.htm>


More information about the Github-comments mailing list