[Github-comments] [geany/geany] `geany.conf` not checked for successful save. (Issue #2993)

xiota notifications at xxxxx
Sat Nov 20 22:14:52 UTC 2021


> So from then on its a message meaning "project save failed" that can be generated for many reasons, not just permissions.

I refer to permissions and read-only files because those are the most common conditions that produce popups.  The messages can be produced several times a minute, even seconds apart, depending on how often the user saves files, switches documents, or performs other activities that prompt project saving.  This makes Geany unusable.

> And as I said above, saving geany.conf actually doesn't check for failure, so making it do so is a "good thing".

You seemed averse to changing the project popups messages.  I suggested unifying config file behavior as a compromise to add checking for files that aren't checked, while reducing the intrusiveness of the current checks. 

> I would advise patience (yeah, I'm not good at it either) until the session-split branch is merged to avoid conflicts and re-bases and then you can do all three files at once.

With the session-split branch (last time I looked at it), keys have to be moved from the current save/load functions to the session variants.  To add a preference requires changing code in at least three locations (struct, save, load).  To move a preference to a session requires changing four (current save/load and session save/load).

In the long run, it would be better to migrate to the stash system.  The current near-duplicate save/load code would become a single "add".  Then the stash system could be extended with session support.  The add/save/load functions could take a bool or have session variants.  Since the stash system uses pointers to the preference variables, no other changes would be required.

> so it would show at least once per session.

Various preferences.

> Just because one project fails due to deliberate permissions does not mean the next one opened is the same, so maybe the flag should be reset when projects change.

The changes I've suggested do *not* eliminate user notification.  It makes them less intrusive.  Users would be able to more easily ignore them.  But that's up to them. 

> That kind of suggests a separate flag for preferences/session and for projects.

That would be fine with me.

> Or alternatively the warning that prefs or project failed to save could be provided by a gtk_info_bar which shows at the top of the edit pane but is not modal and doesn't interrupt the user editing like a dialog does...

That could also work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2993#issuecomment-974719089
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211120/338ced8d/attachment-0001.htm>


More information about the Github-comments mailing list