[Github-comments] [geany/geany] `geany.conf` not checked for successful save. (Issue #2993)

[elextr]

@xiota IIUC the current behaviour is there are messages for "read only", "do you want to overwrite" and maybe other conditions when a project file is first created, because those conditions are explicitly checked, but they are not checked again. 

So from then on its a message meaning  "project save failed" that can be generated for many reasons, not just permissions.  And as I said above, saving `geany.conf` actually doesn't check for failure, so making it do so is a "good thing".

I would advise patience (yeah, I'm not good at it either) until the session-split branch is merged to avoid conflicts and re-bases and then you can do all three files at once.

Then converting the save of all three prefs files to test the return code from `utils_write_file()` and use a common dialog in `dialogs.c` if it fails.  

That common dialog can have a "Show in status bar and window instead" checkbox, but its hard to see how that can be saved in prefs when it can only be selected when saving prefs has failed :grin: so it would show at least once per session.  But that seems useful to me.  Sadly `utils_write_file()` does not return a message string so it can be shown in the dialog, maybe a new version that does is needed.

One thing is that although there is only ever one `geany.conf` and `session.conf` file per session, projects can be opened and closed.  Just because one project fails due to deliberate permissions does not mean the next one opened is the same, so maybe the flag should be reset when projects change.  That kind of suggests a separate flag for preferences/session and for projects.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2993#issuecomment-974582234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211119/626c9343/attachment-0001.htm>