[Github-comments] [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager and terminal (PR #1126)

xiota notifications at xxxxx
Wed Nov 10 01:18:37 UTC 2021


@elextr

> just a warning, every time you force push you are likely to break the copy others are using for testing your changes, which is likely to annoy them.

I force pushed here because @techee asked on another PR for me to combine commits.  So I assumed that was his preference generally.  How would I do that without a force push?

For Geany, a couple were because of conflicts that would need to be resolved manually.  The rest were just because it's fun to rebase.  I'll refrain from any more of those.

> The travis failure isn't you, geany_lua is broken and that stops the build. Probably the build should be fixed one day to continue to other plugins even if one fails.

#1123 fixes the build issue.  @Skif-off Seems to think it's prudent to wait for geany/geany#2930 (Scintilla 5.1.3), but in that thread there's talk of waiting for 5.1.4.

If there are no new data types, the changes are auto-generated.  So if it's holding other things back, the only real downside to just merging and regenerating the file again later is another PR.  If scintilla only add symbols, without removing any, the next update could be delayed further with the only consequence being that new messages can't be used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1126#issuecomment-964692393
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211109/069a6947/attachment-0001.htm>


More information about the Github-comments mailing list