[Github-comments] [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager (PR #1126)

[Jiří Techet]

So far I just looked at the functionality and not the code much yet so just a few observations based on what these patches do:

1. I like the "open directory" and "run terminal" features (maybe I'd just prefer "open terminal" so it's clear that when you invoke it on some script, it won't run the script), but I'm not so sure about the "open externally" feature. The "open externally" feature could potentially execute some code from e.g. scripts and I'd like to avoid such things from inside the plugin, especially when it can happen by accidentally selecting a wrong row in the menu.
2. The configuration option (especially for the terminal) is probably useful, it would just be better to have this as a plugin configuration (the one you specify in Edit->Plugin Preferences or in the plugin manager) and not a per-project configuration option - you want to set this once for all your projects and not on a per-project basis. The plugin currently doesn't use this configuration window - if you want to implement it, you can check some other plugins how they do it.
3. I'd prefer having the toolbar in the sidebar simple and having these new features only accessible from the popup menu.
4. I'd prefer moving these new popup menu items to the very bottom (below "Delete", above "hide sidebar", separated by a separator above and below)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1126#issuecomment-964587660
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211109/52445444/attachment.htm>