[Github-comments] [geany/geany] Ctags update to p5.9.20211031.0 (PR #2984)

[Enrico Tröger]

> I think regex.h was included also before these patches, how was it handled on MINGW?

It was included before but only in `ctags/main/lregex.c`.
On Windows, we use the bundled regex library in `ctags/gnu_regex` and this is added to `AM_CPPFLAGS` in `ctagsMakefile.am` but not in `src/tagmanager/` where it is now **also** included because the `regex-h` include itself is now in a header file.

One solution could be:
```
diff --git a/src/tagmanager/Makefile.am b/src/tagmanager/Makefile.am
index 066192b95..53759db0d 100644
--- a/src/tagmanager/Makefile.am
+++ b/src/tagmanager/Makefile.am
@@ -3,6 +3,12 @@ AM_CPPFLAGS = \
 	-I$(top_srcdir)/ctags/main \
 	-DGEANY_PRIVATE \
 	-DG_LOG_DOMAIN=\"Tagmanager\"
+
+if USE_BUNDLED_REGEX
+noinst_LTLIBRARIES += libgnu_regex.la
+AM_CPPFLAGS += -I$(srcdir)/gnu_regex
+endif
+
 AM_CFLAGS = \
 	$(GTK_CFLAGS) \
 	@LIBGEANY_CFLAGS@
```

I'll try this tomorrow on my Windows machine and see if it'll suffice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2984#issuecomment-962698396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211107/eb75dc5e/attachment.htm>