[Github-comments] [geany/geany] Add option and keybinding to hide menubar (PR #2972)

[xiota]

> But the "hide on startup" option does not work that way.

@elextr  The current implementation does *not* hide the menubar unless a keybinding is set.  That applies to hide on startup.  When hide on startup is set, but no keybinding is set, a message will be displayed in the status window to notify the user that a keybinding must be set before the menubar will be hidden.

> the real problem with hiding the menu is when someone does it accidentally and doesn't know how to get it back. If it was a unbound toggle keybinding I think its fine, the user has to set something to enable it and hopefully will remember their keybinding.

By default, there is no keybinding set, so the user would not be able to hide the menubar accidentally.  Even if a keybinding is set and the user forgets what it is, a message is sent to the status bar window when the menubar is hidden to remind the user how to restore the menubar.

> I agree that the "hide on startup" option is not necessary.

@eht16  Hide on startup is a primary use case that this PR is intended to address.  Restore on startup is basically just to make devs happy.  I already have a couple plugin implementations (Geanypy, Lua script, and C plugin).  I rewrote part of the Lua script to restore on startup while helping a user to get it working.  The first request the user made after getting the script to work was to make it always hide on startup.  (As far as I know, the script has only one user.  So while it may not be representative of all users, the use-case does exist beyond just me.)

If a plugin would be needed anyway to hide on startup, it would be better for for the plugin to control all menubar hiding features.  Dividing this task between Geany and a plugin introduces conflicts that complicate the plugin and can confuse users.

> If implemented with a keybinding, a menu item in the View menu

Adding an option on the view menu would make it more likely for users to accidentally hide the menubar without being able to restore it.  (The option will be inaccessible after the menubar is hidden.)

The current implementation prevents accidentally hiding the menubar by requiring a keybinding to be set.  That would block the (hypothetical) menu option from working, which could lead to user confusion/complaints that the option does not work.

> and an option in the preferences dialog (on the Interface tab, not as Various pref), then it is more visible and via the preferences dialog easier to show the menu bar again. And it is in line with the other show/hide options for Toolbar, Sidebar and Message Window.

This would make the feature more visible, and prone to accidental usage.  Since at least occasional access to the menubar is essential, hiding it should be an advanced feature that only sufficiently motivated users will find and use.

> We could even add a FAQ item to explain how to restore the menu bar.

I wouldn't mind writing it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2972#issuecomment-962647557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211107/a8b69f1a/attachment-0001.htm>