[Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Enrico Tröger]

> @eht16 In fact, `gawk` is not a new depedency, it's already needed by `geany-i18n-m4`. but I still replaced the offending statement because meson discourages from listing source files via wildcards.

Almost. `geany-i18n-m4` requires `AC_PROG_AWK` which supports also other `awk` variants than `gawk`.
I noticed this because the system where I tested the build actually had no `gawk` installed but I was still able to successfully compile Geany with autotools (probably with `mawk` as this is installed on that system).
Maybe Meson supports something similar to use either `gawk` or `mawk` depending on what is available, so we could still have the dynamically generated list.

Found a few more issues:

- `$PREFIX/share/geany/filedefs/filetypes.python.in` is installed as is. But it needs to be preprocessed to replace `@PYTHON_COMMAND@`.

- G_LOG_DOMAIN is not set which results in log messages without the source set, e.g.: `17:53:15: (null) INFO           : Geany 1.38 (git >= 73ab53541), en_GB.UTF-8`. Log messages should look like: `17:54:09: Geany INFO            : Geany 1.38 (git >= 8a30ce2), en_GB.UTF-8`. For the different parts of the code, there are different log domains defined:
CTags
 Classbuilder
Demoplugin
Demoproxy
Export
FileBrowser
Geany 
HTMLChars
MIO 
SaveActions
SplitWindow
Tagmanager

- in the output I found `Running custom install script '/usr/bin/meson --internal gettext install --subdir=po --localedir=share/locale --pkgname=geany --langs=ar@@ast@@be@@bg@@ca@@cs@@da@@de@@el@@en_GB@@es@@et@@eu@@fa@@fi@@fr@@gl@@he@@hi@@hu@@id@@ie@@it@@ja@@kk@@ko@@ku@@lb@@lt@@lv@@mn@@nl@@nn@@pl@@pt@@pt_BR@@ro@@ru@@sk@@sl@@sr@@sv@@tr@@uk@@vi@@zh_CN@@zh_TW'` which looks strange but possibly is fine anyway. At least it seems the language files were probably installed.

- I still have the messages like 
    ```
    msgfmt: ../po/LINGUAS does not exist
    ../geany.desktop.in:5:0: warning: invalid non-blank line
    ../geany.desktop.in:6:0: warning: invalid non-blank line
    ../geany.desktop.in:7:0: warning: invalid non-blank line
    ../geany.desktop.in:14:0: warning: invalid non-blank line
    ```
    I wonder if the missing `../po/LINGUAS` is a problem and what's the consequence.
    The lines about "warning: invalid non-blank line" seems to be related that Meson is using `gettext` to process the .desktop file where previously `intltool` was used. And the `_Keyword...` syntax is specific for `intltool`.
It seems this might be a seperate task like migrating from `intltool` to `gettext` (https://stackoverflow.com/questions/62504873/i18n-merge-file-cant-translate-desktop-file).
Anyway, we need to handle this in some way as the resulting .desktop file is missing items like "Name", "Comment" and "Keywords".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-850972050
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210530/545d43fa/attachment.htm>