[Github-comments] [geany/geany] No localization in Windows version (#2831)

elextr notifications at xxxxx
Tue Jun 22 07:39:42 UTC 2021


> It is clear that Geany used the user-selected locale in Windows, until somebody broke it. It is a bug and should be fixed.

No, as is noted #1919, if `LANG` is not set, GTK, the GUI library, seems to call `setlocale(LC_ALL,"");` and use the result to set its built-in elements to that.  But that doesn't set the rest of the gettext() system as used by Geany because that was initialised before GTK got started.  This resulted in a mixed UI as #1919 discusses.  GTK shouldn't try to set locale over the top of the application and in fact GTK4 now provides a call to disable the offending GTK call to setlocale.

> It is clear that Geany used the user-selected locale in Windows, until somebody broke it. It is a bug and should be fixed.

No, Geany never supported anything but the POSIX environment variables to set its locale.  The fact that one of the libraries Geany uses tried to be smart if `LANG` is not set just shows again that you need to set it, and that was the fix to #1919.

Also note that just because somebody posted something on an issue comment doesn't make it correct, especially when the rest of the comments contradict it.

I can assure you Geany never intentionally followed the Windows locale settings, it has not "broken".  In fact #1757 is still open for anyone to contribute better solutions, but other than convenience scripts to set `LANG` (as used on the OSX port) no solution has been proposed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2831#issuecomment-865676799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210622/0d5aae10/attachment.htm>


More information about the Github-comments mailing list