[Github-comments] [geany/geany] Add support for Kotlin tags (#2778)

[Jan Dolinár]

> unfortunately there are so many changes to the general ctags infrastructure it needs one of the (few) people who know ctags to look at it, the rest of us would spend so much time understanding the basic ctags operation that we simply don't have the time to look at it.

I thought the whole point of the import script by @techee was to make the updates of ctags easy enough so anyone can update them at any time. More frequent updates lead to fewer changes to check, resulting in easier reviews.

> Also I personally don't understand why #2584 changes only 20 files for both tags parsing and a lexer and you change 57 files for just tag parsing? 

If you look at the commit with the [kotlin support](https://github.com/geany/geany/pull/2778/commits/759d56f70e9b1a8a0b26198a8670bdc5119d27b5), you'll see that it is exactly 20 files (7 of which is imported from ctags, 6 in geany code, 3 in tests, and the rest are makefiles and other "infrastructure").  The rest (37 files) comes from updated ctags.

> In fact if your parser requires updated ctags infrastructure features its probably better to make a separate PR for that rather than mix it all in your new language PR.

That is exactly why I separated it in two commits, which you can review separately:
- [update ctags](https://github.com/geany/geany/pull/2778/commits/8eb6e8ac5154286ae0390b96c7949a60ff623b2b)
- [Add support for Kotlin tags](https://github.com/geany/geany/pull/2778/commits/759d56f70e9b1a8a0b26198a8670bdc5119d27b5)

Posting them as two merge requests didn't really make sense to me, since neither really make sense by itself. But if you prefer it that way, I can surely make another PR for the update only. 

Related question: Would you prefer me to update ctags to lowest version required for the kotlin parser, or should I update it to latest stable release? Ctags development is really lively, there has been about 10 new releases since I originally posted this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2778#issuecomment-864589765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210620/bccfe1dd/attachment.htm>