[Github-comments] [geany/geany-plugins] geanynumberedbookmarks shortcuts do not work with numlock on (#1089)

[David Yang]

Found the offending snippet, comparisons to an array of magic number keycodes starting line 1467

`
/* control+shift+number */
	if(ev->state==5) {
		/* could use hardware keycode instead of keyvals but if unable to get keyode then don't
		 * have logical default to fall back on
		*/
		for(i=0;i<10;i++) if((gint)(ev->keyval)==iShiftNumbers[i])
		{
			SetBookMark(doc, i);
			return TRUE;
		}

	}`

can probably fix this, might be some amount of time later though

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1089#issuecomment-874043359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210705/454f18d2/attachment.htm>