[Github-comments] [geany/geany] Improve handling of anonymous tags (PR #3059)

[elextr]

@elextr commented on this pull request.



> @@ -120,7 +120,15 @@ static gboolean init_tag(TMTag *tag, TMSourceFile *file, const tagEntryInfo *tag
 	tag->name = g_strdup(tag_entry->name);
 	tag->type = type;
 	tag->local = tag_entry->isFileScope;
-	tag->pointerOrder = 0;	/* backward compatibility (use var_type instead) */
+	tag->flags = tm_tag_flag_none_t;
+	if (isTagExtraBitMarked(tag_entry, XTAG_ANONYMOUS))
+	{
+		tag->flags |= tm_tag_flag_anon_t;
+		/* Temporarily store kind letter for anon name generation to flags
+		 * as we don't have any other place where to store it. This will
+		 * be cleared later in rename_anon_tags() */
+		tag->flags |= (guint)kind_letter << 16;

@kugel- is right, add the members to the end and its not necessary to bump the ABI.  

The ABI problem really only manifests itself when a distro releases Geany with a new ABI, but not the plugins at the same time (Debian has done that before).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3059#discussion_r772712265
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3059/review/836873121 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211220/62f8abf9/attachment.htm>