[Github-comments] [geany/geany] Improve handling of anonymous tags (PR #3059)

[Thomas Martitz]

@kugel- commented on this pull request.



> @@ -94,14 +101,15 @@ typedef struct TMTag
 	TMSourceFile *file; /**< File in which the tag occurs; NULL for global tags */
 	gulong line; /**< Line number of the tag */
 	gboolean local; /**< Is the tag of local scope */
-	guint pointerOrder;
+	guint flags; /**< Additional flags */

This adds Doxygen documentation for the member, which traditionally approves it for plugin use. Is that your intention? Otherwise I would add a simple comment (like with kind_letter) until someone officially requests this member to be part of the API.

> @@ -836,7 +836,7 @@ find_scope_members (const GPtrArray *tags_array, const gchar *name, TMSourceFile
 
 			/* anonymous type defined in a different file than the variable -
 			 * this isn't the type we are looking for */
-			if (tm_tag_is_anon(test_tag) && (file != test_tag->file || test_tag->file == NULL))
+			if (tm_tag_is_anon(tag) && (file != test_tag->file || test_tag->file == NULL))

This confuses me and Github draws the indentation strangely.

Anyway, I seems wrong to do s/test_tag/tag/, don't you think?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3059#pullrequestreview-836824523
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3059/review/836824523 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211220/4c78fac6/attachment.htm>