[Github-comments] [geany/geany] Move language-specific parts to tm_parser.c (PR #3060)

[Jiří Techet]

There is various language-specific code related to tag manager which is scattered across Geany codebase. First, it makes such code hard to maintain, second, it makes it hard to discover for people adding support for a new parser to Geany. This code includes:

1. Formatting of functions for calltips and popups for sidebar (also for variables). This is language-specific where e.g. function return type can be in front of function for C but behind function for go.
2. Displaying of calltips for object constructors based on certain method name (__init__() arguments after typing `MyClass(` for Python) - there were actually two different implementations of this feature, one for Python, one for D.
3. Code detecting whether scope autocompletion should be triggered - the characters triggering it are specific to used languages.

Since `tm_parser.c` already contains language-specific mappings from parsers, it seems to be a good home for this kind of code.

The only remaining language-specific tag manager related code is the mappings  of tags to the symbol tree in `symbols.c` which I'd like to move to `tm_parser.c` once the various parser pull requests are merged (not to introduce merge conflicts).
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3060

-- Commit Summary --

  * Move function/variable formatting into tm_parser
  * Handle calltips of Python constructors like D constructors
  * Move language-specific part of constructor calltip lookup to tm_parser
  * Move language-specific parts of whether to trigger scope autocompletion to tm_parser
  * Remove invalid python-specific code
  * Display python type annotations correctly formatted

-- File Changes --

    M src/editor.c (131)
    M src/editor.h (2)
    M src/symbols.c (17)
    M src/tagmanager/tm_ctags.c (33)
    M src/tagmanager/tm_parser.c (119)
    M src/tagmanager/tm_parser.h (9)
    M tests/ctags/cython_sample.pyx.tags (2)
    M tests/ctags/py_constructor_arglist.py.tags (2)
    M tests/ctags/simple.py.tags (2)

-- Patch Links --

https://github.com/geany/geany/pull/3060.patch
https://github.com/geany/geany/pull/3060.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3060
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3060 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211219/21aae450/attachment.htm>