[Github-comments] [geany/geany] HACKING:remove rule that shouldn't be used (#2059)

Enrico Tröger notifications at xxxxx
Sat Dec 11 12:16:51 UTC 2021


I suggest to keep it, maybe rephrase a little that the PR author *should* squash at the end of the review in case there are to many iteration commits or "fixups" or so. When done only once at the end, the force-push shouldn't be so bad and the reviewer needs to diff on the diff only once (as @b4n said).
So in the end the current rule keeps recommendation but it's not a must. And it depends on PR itself anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2059#issuecomment-991622470
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211211/e948f329/attachment.htm>


More information about the Github-comments mailing list